-
Notifications
You must be signed in to change notification settings - Fork 350
repair: coarse peer selection by latency #6664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Measurements ⏳
|
5a2017c to
a6342bc
Compare
Performance Measurements ⏳
|
a6342bc to
1a3fe76
Compare
Performance Measurements ⏳
|
1a3fe76 to
5fdbc8d
Compare
Performance Measurements ⏳
|
lidatong
previously approved these changes
Oct 14, 2025
src/discof/repair/fd_policy.h
Outdated
Comment on lines
167
to
168
| FD_POLICY_LATENCY_WORST, /* do a cycle through worst peers 1/7 times to see if any improvements are made */ | ||
| FD_POLICY_LATENCY_BEST, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast slow?
src/discof/repair/fd_policy.h
Outdated
Comment on lines
178
to
184
| fd_policy_dedup_t dedup; /* dedup cache of already sent requests */ | ||
| fd_policy_peers_t peers; /* repair peers (strategy & data) */ | ||
| long tsmax; /* maximum time for an iteration before resetting the DFS to root */ | ||
| long tsref; /* reference timestamp for resetting DFS */ | ||
|
|
||
| fd_forest_iter_t iterf; /* forest iterator */ | ||
| ulong tsreset; /* ms timestamp of last reset of iterf */ | ||
| fd_forest_iter_t iterf; /* forest iterator */ | ||
| ulong tsreset; /* ms timestamp of last reset of iterf */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like extra space?
5fdbc8d to
76f1b3f
Compare
lidatong
approved these changes
Oct 14, 2025
Performance Measurements ⏳
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.